-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX Release] Special case {{#with}}
for isTruthy
#12922
Conversation
Should resepect `isTruthy` on objects.
The failed tests were fixed in glimmerjs/glimmer-vm#71, I merged and restarted the build. |
[BUGFIX Release] Special case `{{#with}}` for `isTruthy`
I've upgraded to 2.4.1 and noticed that this commit broke something in my use case. I'm not completely sure if I'm doing something wrong here (I'm relatively new to Ember), so just wanted to check out with you guys @chadhietala @rwjblue I'm doing this in my component:
.. where invoice & deal are DS.Models and invoice belongsTo deal. Now, because If I do Anyways, something is wrong somewhere but I don't have enough experience to assume where. What do you think? |
Hmm, there was a subsequent PR that ensured the right value was used in the block param, that pull request should have been included in 2.4.0/2.4.1 (though it is possible that I missed it when preparing for the release). Can you open a new issue with a JSBin and/or ember-twiddle.com demo? You can create an object with an isTruthy method returning true and show that the wrong value is used as the block param (instead of setting up the whole ember-data model scenario in the demo). |
@rwjblue Sure, no problem. |
Same problem here, created a JSBin. |
@jcbvm - Same answer 😈 |
Oh lol, created issue #13045 |
Should resepect
isTruthy
on objects.